Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix embedded struct marshalling #57

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Conversation

alecsammon
Copy link
Contributor

Fixes struct marshalling for embedded structs when a json tag is specified.

Currently the following case works, and produces the same result as json.Marshal

type EmbeddedParent struct {
	*EmbeddedChild
}

However this case does not work as expected

type EmbeddedParent struct {
	*EmbeddedChild `json:"embedded"`
}

In the second case the outputted json is flattened, instead of nested as expected.

@alecsammon alecsammon marked this pull request as ready for review July 3, 2024 14:42
@coveralls
Copy link

Coverage Status

coverage: 89.212% (+0.05%) from 89.167%
when pulling 5579d0b on alecsammon:fix_embedded
into e127e90 on liip:master.

@mweibel mweibel enabled auto-merge (rebase) October 3, 2024 06:38
@coveralls
Copy link

Coverage Status

coverage: 89.212% (+0.05%) from 89.167%
when pulling 80f0f5c on alecsammon:fix_embedded
into dc3eac4 on liip:master.

@mweibel mweibel merged commit 80f0f5c into liip:master Oct 3, 2024
5 checks passed
@alecsammon
Copy link
Contributor Author

❤️ - thank you

@mweibel
Copy link
Collaborator

mweibel commented Oct 3, 2024

sorry, got off my radar and just came across this because of another PR coming in :)

@alecsammon
Copy link
Contributor Author

no problem at all - we've been using our own fork for the moment - but can now switch back to use this.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants