Add aarch64 opensuse tumbleweed #1014
Conversation
| @@ -23,7 +23,7 @@ if [ "${LIMA_CIDATA_UDP_DNS_LOCAL_PORT}" -ne 0 ] || [ "${LIMA_CIDATA_TCP_DNS_LOC | |||
| fi | |||
|
|
|||
| # Install minimum dependencies | |||
| if command -v apt-get >/dev/null 2>&1; then | |||
| if hexdump -C -n 4 "$(command -v apt-get)" | grep -qF 'ELF' >/dev/null 2>&1; then | |||
There was a problem hiding this comment.
Could you add a code comment to explain the background?
|
Thanks, but please sign the commit for DCO (run |
Signed-off-by: replicajune <replicajune@users.noreply.github.com>
apt-get "command -v" detection matches on opensuse and runs a script that fails to run with some of the option used bellow. Signed-off-by: replicajune <replicajune@users.noreply.github.com>
…r package managers Signed-off-by: replicajune <replicajune@users.noreply.github.com>
|
hello @AkihiroSuda, thank you for the time you're spending on the PR, much appreciated :)
|
|
Thanks, but please use real name |
|
the name I use on github (and for other tech related stuff) comply with the definition of real name of DCO as far as I can see (https://github.com/cncf/foundation/blob/main/dco-guidelines.md: "Your real name is the name you convey to people in the community for them to use to identify you as you") is this ok for you ? |
Thanks, wasn't aware of that guideline.
Maybe. |
This merge request is related to the issue #1011 and is aiming at being able to user OpenSuse with the current script approach to package manager detection