Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add support for reading template from stdin #1250

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

deitch
Copy link
Contributor

@deitch deitch commented Dec 14, 2022

Fixes #1247

Some comments:

  • if --tty is not provided and the template is read from stdin, then it defaults to --tty=false
  • if --tty=true as a CLI flag and the template is read from stdin, return an error
  • if --name as a CLI flag is not provided and the template is read from stdin, return an error
  • uses - as the indicator for stdin, inline with what most Unix-style programs do

Signed-off-by: Avi Deitcher <avi@deitcher.net>
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda added this to the v0.14.2 milestone Dec 22, 2022
@AkihiroSuda AkihiroSuda merged commit 224c965 into lima-vm:master Dec 22, 2022
@deitch deitch deleted the template-stdin branch December 22, 2022 14:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ability to provide template via stdin?
2 participants