Support for VBox driver #1277
Closed
Support for VBox driver #1277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a fair deal of copy/paste, between pkg/vz/disk and pkg/vbox/disk And there is some similar cleanup to do, between pkg/qemu and pkg/vbox... |
balajiv113
reviewed
Jan 7, 2023
afbjorklund
force-pushed
the
vbox
branch
2 times, most recently
from
faf9412 to
0855204
Compare
afbjorklund
force-pushed
the
vbox
branch
2 times, most recently
from
ee929da to
bce1506
Compare
Merged
This is a legacy driver for Oracle VirtualBox, x86_64 only. It also has support for shared folders and hostonly networks, but they are not implemented just yet (sshfs and nat only) Deletion does not work properly, due to the VM "registry". Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
The VM was registered after creation (Start) It needs to be unregistered, after deletion. Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
|
To be moved to an external driver, once framework is available. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a legacy driver for Oracle VirtualBox, x86_64 only.
It also has support for shared folders and hostonly networks,
but they are not implemented just yet (sshfs and nat only)
Closes #1287