Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: allow rosetta fields to be overridden #1413

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

pendo324
Copy link
Contributor

Allow Rosetta fields to be overridden by making them pointers and setting default values based the same way they are set for other config options.

Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324 pendo324 force-pushed the rosetta-fields-overridable branch from 985a84d to e339944 Compare March 10, 2023 00:59
@AkihiroSuda AkihiroSuda requested a review from jandubois March 10, 2023 03:04
@AkihiroSuda AkihiroSuda added this to the v0.16.0 milestone Mar 10, 2023
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jandubois jandubois merged commit f8e46c6 into lima-vm:master Mar 10, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants