limactl: add `--cpus`, `--memory`, `--mount-type`, `--vm-type`, ... #1468

AkihiroSuda · 2023-04-08T15:13:33Z

limactl create, limactl start, limactl edit:

--cpus=INT (Similar to colima start --cpu, but the flag name is slightly different)
--dns=IP (Similar to colima start --dns)
--memory=FLOAT (Similar to colima start --memory)
--mount=DIR[:w] (Similar to colima start --mount)
--mount-type=(reverse-sshfs|9p|virtiofs) (Similar to colima start --mount-type)
--mount-writable=BOOL
--network=(lima:shared|lima:bridged|lima:host|lima:user-v2|vzNAT)
--rosetta=BOOL

limactl create and limactl start only:

--arch=(x86_64|aarch64|riscv64) (Similar to colima start --arch)
--containerd=(user|system|user+system|none)
--disk=FLOAT (Similar to colima start --disk)
--vm-type=(qemu|vz) (Similar to colima start --vm-type)

afbjorklund · 2023-04-09T10:43:00Z

In the legacy systems, they used MiB instead (probably so you could do things like 0.5GiB, when using integers?)

   --virtualbox-cpu-count "1"										number of CPUs for the machine (-1 to use the number of CPUs available) [$VIRTUALBOX_CPU_COUNT]
   --virtualbox-memory "1024"										Size of memory for host in MB [$VIRTUALBOX_MEMORY_SIZE]
   --virtualbox-disk-size "20000"									Size of disk for host in MB [$VIRTUALBOX_DISK_SIZE]

   --qemu-cpu-count "1"											Number of CPUs
   --qemu-memory "1024"											Size of memory for host in MB
   --qemu-disk-size "20000"										Size of disk for host in MB

For a modern system, it makes much more sense to use GiB. It also looks better, next to the vCPU count. (e.g. 4 / 4)

      --cpus int            number of CPUs
      --memory int          memory in GiB

afbjorklund · 2023-04-09T10:44:29Z

cmd/limactl/editflags/editflags.go

+	flags.Int("memory", 0, "memory in GiB") // colima-compatible
+	_ = cmd.RegisterFlagCompletionFunc("memory", func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
+		return []string{"1", "2", "4", "8", "16", "32"}, cobra.ShellCompDirectiveNoFileComp
+	})


Should also add "disk" here, ("disk in GiB")

I have some concern here, because disk size can only ever be increased. The only way to shrink disk size is by destroying and re-creating the instance, losing all your data.

So this is not something that you should casually do. Or it should require a confirmation prompt for the user to acknowledge (disabled by --tty=false).

For new instances it can be casually done

For new instances it can be casually done

Yes, my concern is purely about limectl edit default --disk 500GiB, and then being unable to ever shrink it again.

Could disable (or prompt) the feature to edit the disk size, until grow and shrink has been implemented ?

Changing the disk size in lima.yaml should resize the disk #1448

Yes, --disk should not be implemented until Lima can grow the disk automatically.

FWIW, I don't expect us to ever be able to shrink disks; is this even possible?

afbjorklund · 2023-04-09T10:49:06Z

It should probably repeat the defaults ?

      --cpus int            number of CPUs (default 4)
      --memory int          memory in GiB (default 4)

Or would that information be misleading, if it is different in the template or in the override ?

jandubois · 2023-04-09T19:33:59Z

For a modern system, it makes much more sense to use GiB. It also looks better, next to the vCPU count. (e.g. 4 / 4)
      --cpus int            number of CPUs
      --memory int          memory in GiB

I don't understand why "memory in GiB" should be an integer. Using rational numbers works just fine:

$ l edit alpine --set '.memory = "4.5GiB"'
WARN[0000] `--set` is experimental
INFO[0000] Instance "alpine" configuration edited
[...]
$ ps -ef | grep qemu
  501 26304 26294   0 12:30pm ttys000    0:09.16 /usr/local/bin/qemu-system-x86_64 -m 4608 ...

jandubois · 2023-04-09T19:40:43Z

It should probably repeat the defaults ?
      --cpus int            number of CPUs (default 4)
      --memory int          memory in GiB (default 4)
Or would that information be misleading, if it is different in the template or in the override ?

I think this is fine; it shows the built-in defaults, not the current values.

jandubois · 2023-04-09T19:43:03Z

Just for the record, I did have some concerns about this being yet another redundant way to do something that is already possible (with the --set option). But after consideration I think the yq syntax is maybe too obscure for the casual user, so having a shortcut for the most common settings is justified.

AkihiroSuda · 2023-05-22T07:42:25Z

I don't understand why "memory in GiB" should be an integer.

I’m trying to follow colima flags (when possible)

jandubois · 2023-05-22T07:59:40Z

I don't understand why "memory in GiB" should be an integer.

I’m trying to follow colima flags (when possible)

That doesn't make much sense to me; by supporting fractional sizes in Lima we would be supporting a superset of what colima supports. All integer arguments would still be valid. And when colima decides to support fractional sizes as well in the future, they can simply pass them through and everything will just continue to work.

Why should the user not be allowed to write --memory 2.5?

AkihiroSuda · 2023-05-22T15:17:47Z

Why should the user not be allowed to write --memory 2.5?

Updated to allow this

jandubois · 2023-05-22T21:28:00Z

Why should the user not be allowed to write --memory 2.5?

Updated to allow this

Thanks! Now we just have to make it accept --memory 2⅞ as a synonym for --memory 2.875 😄

j/k

afbjorklund · 2023-06-06T15:58:51Z

--containerd=(user|system|user+system|none)

Translated these into yq: ".containerd.user = true"

Editing the mounts requires some more knowledge.

.mounts += {"location": "foo", "mountPoint": "bar"}

AkihiroSuda · 2023-06-07T13:59:09Z

Editing the mounts requires some more knowledge.

.mounts += {"location": "foo", "mountPoint": "bar"}

Yes, complicated configs should be still provided via yq or YAML.

AkihiroSuda · 2023-06-23T03:18:16Z

Will rebase after merging:

limactl: add limactl create command #1643

AkihiroSuda · 2023-07-23T09:14:11Z

Rebased

jandubois

Thanks, LGTM; only cosmetics feedback. Making completion dynamic maybe not worth the effort.

Personally i wouldn't bother marking --network, --set, and --rosetta as experimental, just to make a log.Warn call when they are used. Do you expect to change them in a backward-incompatible way?

cmd/limactl/editflags/editflags.go

AkihiroSuda · 2023-07-26T06:40:59Z

Personally i wouldn't bother marking --network, --set, and --rosetta as experimental, just to make a log.Warn call when they are used. Do you expect to change them in a backward-incompatible way?

We can revisit this when we make vz driver and user-v2 network default

cmd/limactl/editflags/editflags.go

jandubois

I'm fine with merging this as is, and improving tab completion later.

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

AkihiroSuda added the area/cli limactl CLI user experience label Apr 8, 2023

AkihiroSuda added this to the v0.16.0 (tentative) milestone Apr 8, 2023

AkihiroSuda added impact/changelog enhancement New feature or request labels Apr 8, 2023

afbjorklund reviewed Apr 9, 2023

View reviewed changes

AkihiroSuda modified the milestones: v0.16.0, v0.17.0 (tentative) May 22, 2023

AkihiroSuda force-pushed the edit-flags branch 4 times, most recently from f015da5 to b1e2616 Compare May 22, 2023 15:13

AkihiroSuda marked this pull request as ready for review May 22, 2023 15:17

AkihiroSuda force-pushed the edit-flags branch from b1e2616 to ee3fa1f Compare May 24, 2023 14:08

AkihiroSuda force-pushed the edit-flags branch from ee3fa1f to 9868bfc Compare June 6, 2023 11:47

AkihiroSuda requested a review from a team June 6, 2023 11:49

afbjorklund mentioned this pull request Jun 17, 2023

Add start flag for choosing the rootful template or containerd instead #1636

Closed

AkihiroSuda mentioned this pull request Jun 18, 2023

Add rootful flag to start for rootful template #1637

Closed

afbjorklund mentioned this pull request Jun 19, 2023

feat: Allow creating lima instances podman-desktop/podman-desktop#2902

Closed

AkihiroSuda mentioned this pull request Jul 17, 2023

update buildkit to v0.12.0 containerd/nerdctl#2374

Merged

AkihiroSuda force-pushed the edit-flags branch from 9868bfc to 369d597 Compare July 23, 2023 09:12

AkihiroSuda force-pushed the edit-flags branch 3 times, most recently from 2d86dfa to 60a8c95 Compare July 23, 2023 10:16

AkihiroSuda mentioned this pull request Jul 24, 2023

v0.17 planning #1681

Closed

jandubois previously approved these changes Jul 26, 2023

View reviewed changes

cmd/limactl/editflags/editflags.go Outdated Show resolved Hide resolved

cmd/limactl/editflags/editflags.go Outdated Show resolved Hide resolved

cmd/limactl/editflags/editflags.go Outdated Show resolved Hide resolved

AkihiroSuda dismissed jandubois’s stale review via 34c3687 July 26, 2023 06:39

AkihiroSuda force-pushed the edit-flags branch from 60a8c95 to 34c3687 Compare July 26, 2023 06:39

jandubois reviewed Jul 26, 2023

View reviewed changes

cmd/limactl/editflags/editflags.go Outdated Show resolved Hide resolved

jandubois previously approved these changes Jul 26, 2023

View reviewed changes

AkihiroSuda dismissed jandubois’s stale review via f211a4f July 26, 2023 07:38

AkihiroSuda force-pushed the edit-flags branch from 34c3687 to f211a4f Compare July 26, 2023 07:38

limactl: add --cpus, --memory, --mount-type, --vm-type, ...

3b8e0ce

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

AkihiroSuda force-pushed the edit-flags branch from f211a4f to 3b8e0ce Compare July 26, 2023 07:40

jandubois approved these changes Jul 26, 2023

View reviewed changes

AkihiroSuda merged commit bd7048f into lima-vm:master Jul 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

limactl: add `--cpus`, `--memory`, `--mount-type`, `--vm-type`, ... #1468

limactl: add `--cpus`, `--memory`, `--mount-type`, `--vm-type`, ... #1468

AkihiroSuda commented Apr 8, 2023 •

edited

Loading

afbjorklund commented Apr 9, 2023

afbjorklund Apr 9, 2023

jandubois Apr 9, 2023

AkihiroSuda Apr 10, 2023

jandubois Apr 10, 2023

afbjorklund May 1, 2023 •

edited

Loading

jandubois May 1, 2023

afbjorklund commented Apr 9, 2023

jandubois commented Apr 9, 2023

jandubois commented Apr 9, 2023

jandubois commented Apr 9, 2023 •

edited

Loading

AkihiroSuda commented May 22, 2023

jandubois commented May 22, 2023

AkihiroSuda commented May 22, 2023

jandubois commented May 22, 2023 •

edited

Loading

afbjorklund commented Jun 6, 2023 •

edited

Loading

AkihiroSuda commented Jun 7, 2023

AkihiroSuda commented Jun 23, 2023

AkihiroSuda commented Jul 23, 2023

jandubois left a comment

AkihiroSuda commented Jul 26, 2023

jandubois left a comment

limactl: add --cpus, --memory, --mount-type, --vm-type, ... #1468

limactl: add --cpus, --memory, --mount-type, --vm-type, ... #1468

Conversation

AkihiroSuda commented Apr 8, 2023 • edited Loading

afbjorklund commented Apr 9, 2023

afbjorklund Apr 9, 2023

Choose a reason for hiding this comment

jandubois Apr 9, 2023

Choose a reason for hiding this comment

AkihiroSuda Apr 10, 2023

Choose a reason for hiding this comment

jandubois Apr 10, 2023

Choose a reason for hiding this comment

afbjorklund May 1, 2023 • edited Loading

Choose a reason for hiding this comment

jandubois May 1, 2023

Choose a reason for hiding this comment

afbjorklund commented Apr 9, 2023

jandubois commented Apr 9, 2023

jandubois commented Apr 9, 2023

jandubois commented Apr 9, 2023 • edited Loading

AkihiroSuda commented May 22, 2023

jandubois commented May 22, 2023

AkihiroSuda commented May 22, 2023

jandubois commented May 22, 2023 • edited Loading

afbjorklund commented Jun 6, 2023 • edited Loading

AkihiroSuda commented Jun 7, 2023

AkihiroSuda commented Jun 23, 2023

AkihiroSuda commented Jul 23, 2023

jandubois left a comment

Choose a reason for hiding this comment

AkihiroSuda commented Jul 26, 2023

jandubois left a comment

Choose a reason for hiding this comment

limactl: add `--cpus`, `--memory`, `--mount-type`, `--vm-type`, ... #1468

limactl: add `--cpus`, `--memory`, `--mount-type`, `--vm-type`, ... #1468

AkihiroSuda commented Apr 8, 2023 •

edited

Loading

afbjorklund May 1, 2023 •

edited

Loading

jandubois commented Apr 9, 2023 •

edited

Loading

jandubois commented May 22, 2023 •

edited

Loading

afbjorklund commented Jun 6, 2023 •

edited

Loading