qemu: disable pdpe1gb on Intel Mac #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
force-pushed
the
qemu-disable-pdpe1gb
branch
from
2b2f6d1 to
8c450e7
Compare
jandubois
previously approved these changes
Apr 14, 2023
There was a problem hiding this comment.
I haven't tested it, but patch looks good.
I'm just confused why this is not required with earlier versions of qemu; don't they enable large page sizes by default?
The SO entry seems to describe a different error/symptom; just the workaround seems to be the same.
But if prevents the crash, then this should be good.
jandubois
reviewed
Apr 14, 2023
https://stackoverflow.com/a/72863744/5167443 Workaround for issue 1485 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
qemu-disable-pdpe1gb
branch
from
8c450e7 to
6179bba
Compare
QEMU v8.0.0-rc1 bumped up the EDK2 binary (https://gitlab.com/qemu-project/qemu/-/commit/86305e864191123dcf87c3af639fddfc59352ac6), that might be the reason. |
jandubois
approved these changes
Apr 14, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://stackoverflow.com/a/72863744/5167443
Workaround for #1485