Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow leaving additional disks unformatted #1516

Merged
merged 3 commits into from
Jul 27, 2023

Conversation

afbjorklund
Copy link
Member

@afbjorklund afbjorklund commented Apr 28, 2023

Default to a simple string with name, just like before.

additionalDisks:
- "disk"

But also allow skipping the partitioning and formatting.

additionalDisks:
- name: "disk"
  format: true
  fsType: "ext4"

Example 1)

Like when running something like ceph, which uses LVM.

It requires the entire disk device to be "raw", unformatted:

additionalDisks:
- name: "disk"
  format: false

https://docs.ceph.com/en/latest/cephadm/install/

A storage device is considered available if all of the following conditions are met:

  • The device must have no partitions.
  • The device must not have any LVM state.
  • The device must not be mounted.
  • The device must not contain a file system.
  • The device must not contain a Ceph BlueStore OSD.
  • The device must be larger than 5 GB.

Example 2)

Also allow using something else than "ext4", like "xfs".

Or for adding custom arguments, such as with glusterfs:

additionalDisks:
- name: "disk"
  format: true
  fsType: "xfs"
  fsArgs: ["-i","size=512"]

https://docs.gluster.org/en/latest/Quick-Start-Guide/Quickstart/

The inode size is set to 512 bytes to accommodate for the extended attributes used by GlusterFS.


Closes #1393

@afbjorklund afbjorklund force-pushed the advanced-disks branch 3 times, most recently from a23bd92 to cc0f2af Compare April 29, 2023 11:50
@afbjorklund afbjorklund marked this pull request as ready for review April 29, 2023 11:59
@afbjorklund afbjorklund marked this pull request as draft April 29, 2023 12:00
@AkihiroSuda
Copy link
Member

Is this still a draft?

@afbjorklund
Copy link
Member Author

afbjorklund commented Jul 25, 2023

I think I put it in a draft, mostly in order to not interfere with the release at that time. Also haven't tested it since.

Will rebase

@afbjorklund afbjorklund force-pushed the advanced-disks branch 2 times, most recently from 2abdc61 to 3809a9a Compare July 25, 2023 19:12
Default to a simple string with name, just like before.

Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
Also allow using something else than "ext4", like "xfs".

Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
For instance when running glusterfs, it needs xfs args.

Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
@afbjorklund afbjorklund marked this pull request as ready for review July 25, 2023 19:39
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda added this to the v0.17.0 milestone Jul 26, 2023
@AkihiroSuda AkihiroSuda merged commit 4761cf5 into lima-vm:master Jul 27, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add functionality to add disk devices without formatting them
3 participants