Add "plain" mode (disables mounts, port forwarding, containerd, etc.) #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draft
```bash limactl start --plain ``` When the "plain" mode is enabled: - the YAML properties for mounts, port forwarding, containerd, etc. will be ignored - guest agent will not be running - dependency packages like sshfs will not be installed into the VM User-specified provisioning scripts will be still executed. Fixes issue 1739 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Closed
balajiv113
reviewed
Sep 28, 2023
| @@ -240,7 +240,11 @@ func watchHostAgentEvents(ctx context.Context, inst *store.Instance, haStdoutPat | |||
| return true | |||
| } | |||
|
|
|||
| logrus.Infof("READY. Run `%s` to open the shell.", LimactlShellCmd(inst.Name)) | |||
| if *inst.Config.Plain { | |||
| logrus.Infof("READY. Run `ssh -F %q lima-%s` to open the shell.", inst.SSHConfigFile, inst.Name) | |||
There was a problem hiding this comment.
Y not use LimactlShellCmd(inst.Name) here ?? Ssh connection stays the same right evn for plan mode ?
There was a problem hiding this comment.
Because plain mode users are less likely to prefer lima-ist commands.
The limactl shell command continue to work.
There was a problem hiding this comment.
I still think the lima wrapper (but only that script, not the others) belongs to the "minimal" footprint.
But I suppose ssh is even more "plain".
Or maybe: lima-ssh lima-default
balajiv113
approved these changes
Sep 28, 2023
This comment was marked as resolved.
This comment was marked as resolved.
|
Having multiple wrapper scripts is confusing, and "plain" mode users are likely to prefer plain SSH command that can be also integrated to other tools such as rsync, fabric, etc. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the "plain" mode is enabled:
User-specified provisioning scripts will be still executed.
Fixes:
limactl create: add--plainflag to disable mounts, port forwarding, containerd, etc. #1739