Update selinux label from container_file_t to nfs_t #1965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
added
guest/el8
AkihiroSuda
reviewed
Oct 30, 2023
| @@ -12,7 +12,7 @@ if [ "$#" -ne 1 ]; then | |||
| fi | |||
|
|
|||
| NAME="$1" | |||
| expected="context=system_u:object_r:container_file_t:s0" | |||
| expected="context=system_u:object_r:nfs_t:s0" | |||
There was a problem hiding this comment.
Could you add a comment to explain why nfs_t?
There was a problem hiding this comment.
Shall we use the same comment as in description?
There was a problem hiding this comment.
Also when compared with 9p on qemu, it also using nfs_t. So I think we're using this label as all those mounts are remote mounts.
AkihiroSuda
reviewed
Oct 30, 2023
| @@ -14,7 +14,7 @@ if [ -d /sys/fs/selinux ]; then | |||
| for line in $(grep -n virtiofs </etc/fstab | cut -d':' -f1); do | |||
| OPTIONS=$(awk -v line="$line" 'NR==line {print $4}' /etc/fstab) | |||
| if [[ ${OPTIONS} != *"context"* ]]; then | |||
| sed -i -e "$line""s/comment=cloudconfig/comment=cloudconfig,context=\"system_u:object_r:container_file_t:s0\"/g" /etc/fstab | |||
| sed -i -e "$line""s/comment=cloudconfig/comment=cloudconfig,context=\"system_u:object_r:nfs_t:s0\"/g" /etc/fstab | |||
There was a problem hiding this comment.
Could you add a comment to explain why nfs_t?
AkihiroSuda
reviewed
Oct 30, 2023
| @@ -14,7 +14,7 @@ mkdir -p /mnt/lima-rosetta | |||
|
|
|||
| #Check selinux is enabled by kernel | |||
| if [ -d /sys/fs/selinux ]; then | |||
| mount -t virtiofs vz-rosetta /mnt/lima-rosetta -o context="system_u:object_r:container_file_t:s0" | |||
| mount -t virtiofs vz-rosetta /mnt/lima-rosetta -o context="system_u:object_r:nfs_t:s0" | |||
There was a problem hiding this comment.
Could you add a comment to explain why nfs_t?
When using vz & virtiofs, initially container_file_t selinux label was considered which works perfectly for container work loads but it might break for other work loads if the process is running with different label. Also these are the remote mounts from the host machine, so keeping the label as nfs_t fits right. Package container-selinux by default adds rules for nfs_t context which allows container workloads to work as well. Signed-off-by: T K Chandra Hasan <t.k.chandra.hasan@ibm.com>
hasan4791
force-pushed
the
fix-selabel
branch
from
6f16f21 to
81a4904
Compare
AkihiroSuda
reviewed
Oct 30, 2023
| @@ -14,7 +14,16 @@ if [ -d /sys/fs/selinux ]; then | |||
| for line in $(grep -n virtiofs </etc/fstab | cut -d':' -f1); do | |||
| OPTIONS=$(awk -v line="$line" 'NR==line {print $4}' /etc/fstab) | |||
| if [[ ${OPTIONS} != *"context"* ]]; then | |||
| sed -i -e "$line""s/comment=cloudconfig/comment=cloudconfig,context=\"system_u:object_r:container_file_t:s0\"/g" /etc/fstab | |||
| ########################################################################################## | |||
| ## When using vz & virtiofs, initially container_file_t selinux label | |||
There was a problem hiding this comment.
Sorry, looks like just a glitch of github web UI
AkihiroSuda
approved these changes
Oct 30, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using vz & virtiofs, initially container_file_t selinux label was considered which works perfectly for container work loads but it might break for other work loads if the process is running with different label. Also these are the remote mounts from the host machine, keeping the label as nfs_t fits right. Package "container-selinux" by default adds rules for nfs_t context which allows container workloads to work as well.