docker{,-rootful}.yaml: Use param in docker templates
#2515
Conversation
|
Once #2498 is merged, I will rebase onto the main branch and then mark this as ready for review. |
norio-nomura
force-pushed
the
use-param-in-docker-templates
branch
from
8741129 to
e5a135d
Compare
By passing the `--set .param.ContainerdImageStore=true` option to `limactl {create,start,edit}`, the `.features."containerd-snapshotter"` option will be enabled in `docker/daemon.json` inside the VM.
Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
By passing the `--set .param.Rootful=true` option to `limactl {create,start,edit}`, Docker inside the VM will run in rootful mode.
Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
…m.Rootful=true` in `docker.yaml`. Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
…ootless Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
norio-nomura
force-pushed
the
use-param-in-docker-templates
branch
from
e5a135d to
cdb7732
Compare
|
Is this still draft? |
|
Could it be that the change to Ready for review will not be notified? I switched to Ready for review. |
- Use `if then else fi` instead of `||` - Use long-from options - Omit double quotes during variable expansion where it is clear that spaces are not included - Use upper case on param variable names - Use wrapper functions instead variable expansion. e.g.(`systemctl_wrapper`) - Assign param variable to shell variable to making it easier to read cloud-init-output.log - Remove `systemctl --user start dbus` since it not required any more - Add some comments to describe the intentions that are difficult to infer from the code Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
|
Updated to apply reviews |
|
Updated PR description:
|
|
Looks super-complicated to me. |
param.CONTAINERD_IMAGE_STORE is still acceptable? |
I think we should go through a few rounds of simplifying it before passing judgement. |
|
For |
Since this option allows you to turn complicated settings on and off with a single option, it’s naturally going to seem complicated. |
|
Sorry, I didn't get around to do another round of code review yet; I wrote #2520 instead to explain my general view/vision of where we should be going with this. I would like to continue to discuss this PR to see if we can't get it into a shape where we agree that having a combined template is better than 2 separate ones. I don't know if we will get there, but I think we should try. |
You don't have to be sorry, it was a hot day and it felt "too long" - I should have given it a proper review. My bad. |
I still feel bad about param.ContainerdImageStore, but I was referring to the length of the new templates (doubled). Switching from Bourne shell to Bash, also takes some getting used to. Simple things like |
I just wanted to let you know that this issue is still on my radar, but I will be offline/travelling until the end of the month and won't have time to look at it again until I'm back. |
based on #2498
docker.yaml: add.param.CONTAINERD_IMAGE_STOREBy passing the
--set .param.CONTAINERD_IMAGE_STORE=trueoption tolimactl {create,start,edit}, the.features."containerd-snapshotter"option will be enabled indocker/daemon.jsoninside the VM.docker.yaml: add.param.ROOTFULBy passing the
--set .param.ROOTFUL=trueoption tolimactl {create,start,edit}, Docker inside the VM will run in rootful mode.docker-rootful.yaml: make everything common except for setting.param.ROOTFUL=trueindocker.yaml.Thanks,