-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Support configuring mount locations within guests #867
Conversation
Needs documentation in Replacing the empty |
b1786d9
to
b47cb8f
Compare
Updated the field name to |
b47cb8f
to
310f954
Compare
b8fbd83
to
72dbe98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
I have some nit-picky comments though. Feel free to address, or maybe @AkihiroSuda is willing to merge as-is; I don't feel too strongly about them.
I also just noticed that there is another field Line 41 in d6aa0d4
For consistency it would be nice to rename that as well to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why this comment is still pending; Github is getting confused.
Closes lima-vm#659 Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
72dbe98
to
d3df001
Compare
Updated the logs and Target -> MountPoint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM.
Ok to merge @AkihiroSuda?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Closes #659
Tested with both sshfs and 9p and confirmed that the mounts were configured in the location specified by
mounts[*].mountPoint
.eg: