nvmm is tested and works fine

[iamleot]

At least on NetBSD/amd64 -current(-ish) it works well.

[afbjorklund]

But -cpu host failed, right ? Did -cpu max work, btw ?

• Not all OS with -accel has -cpu host option #900

[afbjorklund]

@iamleot do the unit tests pass, on netbsd ?

go test ./...

[iamleot]

But -cpu host failed, right ? Did -cpu max work, btw ?

• Not all OS with -accel has -cpu host option #900

Yes, -cpu max works.

[iamleot]

@iamleot do the unit tests pass, on netbsd ?

go test ./...

If I try on a clean checked out source it fails with:

$ go test -v ./...
go: github.com/containerd/containerd@v1.6.6 requires
        github.com/AdaLogics/go-fuzz-headers@v0.0.0-20210715213245-6c3934b029d8: missing go.sum entry; to add it:
        go mod download github.com/AdaLogics/go-fuzz-headers

I guess I'm missing something obvious, right? :)

[iamleot]

I have done a go mod download github.com/AdaLogics/go-fuzz-headers and after that:

$ go test ./...
# github.com/lima-vm/lima/pkg/cidata
pkg/cidata/template_test.go:8:2: missing go.sum entry needed to verify package gotest.tools/v3/assert (imported by github.com/lima-vm/lima/pkg/cidata) is provided by exactly one module; to add:
        go get -t github.com/lima-vm/lima/pkg/cidata
FAIL    github.com/lima-vm/lima/pkg/cidata [setup failed]
# github.com/lima-vm/lima/pkg/downloader
pkg/cidata/template_test.go:8:2: missing go.sum entry needed to verify package gotest.tools/v3/assert (imported by github.com/lima-vm/lima/pkg/cidata) is provided by exactly one module; to add:
        go get -t github.com/lima-vm/lima/pkg/cidata
FAIL    github.com/lima-vm/lima/pkg/downloader [setup failed]
# github.com/lima-vm/lima/pkg/guestagent/procnettcp
pkg/cidata/template_test.go:8:2: missing go.sum entry needed to verify package gotest.tools/v3/assert (imported by github.com/lima-vm/lima/pkg/cidata) is provided by exactly one module; to add:
        go get -t github.com/lima-vm/lima/pkg/cidata
FAIL    github.com/lima-vm/lima/pkg/guestagent/procnettcp [setup failed]
# github.com/lima-vm/lima/pkg/hostagent/dns
pkg/cidata/template_test.go:8:2: missing go.sum entry needed to verify package gotest.tools/v3/assert (imported by github.com/lima-vm/lima/pkg/cidata) is provided by exactly one module; to add:
        go get -t github.com/lima-vm/lima/pkg/cidata
FAIL    github.com/lima-vm/lima/pkg/hostagent/dns [setup failed]
# github.com/lima-vm/lima/pkg/limayaml
pkg/cidata/template_test.go:8:2: missing go.sum entry needed to verify package gotest.tools/v3/assert (imported by github.com/lima-vm/lima/pkg/cidata) is provided by exactly one module; to add:
        go get -t github.com/lima-vm/lima/pkg/cidata
FAIL    github.com/lima-vm/lima/pkg/limayaml [setup failed]
# github.com/lima-vm/lima/pkg/networks
pkg/cidata/template_test.go:8:2: missing go.sum entry needed to verify package gotest.tools/v3/assert (imported by github.com/lima-vm/lima/pkg/cidata) is provided by exactly one module; to add:
        go get -t github.com/lima-vm/lima/pkg/cidata
FAIL    github.com/lima-vm/lima/pkg/networks [setup failed]
# github.com/lima-vm/lima/pkg/osutil
pkg/cidata/template_test.go:8:2: missing go.sum entry needed to verify package gotest.tools/v3/assert (imported by github.com/lima-vm/lima/pkg/cidata) is provided by exactly one module; to add:
        go get -t github.com/lima-vm/lima/pkg/cidata
FAIL    github.com/lima-vm/lima/pkg/osutil [setup failed]
# github.com/lima-vm/lima/pkg/qemu
pkg/cidata/template_test.go:8:2: missing go.sum entry needed to verify package gotest.tools/v3/assert (imported by github.com/lima-vm/lima/pkg/cidata) is provided by exactly one module; to add:
        go get -t github.com/lima-vm/lima/pkg/cidata
FAIL    github.com/lima-vm/lima/pkg/qemu [setup failed]
# github.com/lima-vm/lima/pkg/sshutil
pkg/cidata/template_test.go:8:2: missing go.sum entry needed to verify package gotest.tools/v3/assert (imported by github.com/lima-vm/lima/pkg/cidata) is provided by exactly one module; to add:
        go get -t github.com/lima-vm/lima/pkg/cidata
FAIL    github.com/lima-vm/lima/pkg/sshutil [setup failed]
?       github.com/lima-vm/lima/cmd/limactl     [no test files]
?       github.com/lima-vm/lima/pkg/guestagent  [no test files]
?       github.com/lima-vm/lima/pkg/guestagent/api      [no test files]
?       github.com/lima-vm/lima/pkg/guestagent/api/client       [no test files]
?       github.com/lima-vm/lima/pkg/guestagent/api/server       [no test files]
ok      github.com/lima-vm/lima/pkg/guestagent/iptables (cached)
?       github.com/lima-vm/lima/pkg/hostagent   [no test files]
?       github.com/lima-vm/lima/pkg/hostagent/api       [no test files]
?       github.com/lima-vm/lima/pkg/hostagent/api/client        [no test files]
?       github.com/lima-vm/lima/pkg/hostagent/api/server        [no test files]
?       github.com/lima-vm/lima/pkg/hostagent/events    [no test files]
?       github.com/lima-vm/lima/pkg/httpclientutil      [no test files]
?       github.com/lima-vm/lima/pkg/httputil    [no test files]
?       github.com/lima-vm/lima/pkg/iso9660util [no test files]
?       github.com/lima-vm/lima/pkg/localpathutil       [no test files]
?       github.com/lima-vm/lima/pkg/lockutil    [no test files]
?       github.com/lima-vm/lima/pkg/logrusutil  [no test files]
?       github.com/lima-vm/lima/pkg/networks/reconcile  [no test files]
?       github.com/lima-vm/lima/pkg/qemu/const  [no test files]
?       github.com/lima-vm/lima/pkg/qemu/imgutil        [no test files]
?       github.com/lima-vm/lima/pkg/start       [no test files]
?       github.com/lima-vm/lima/pkg/store       [no test files]
?       github.com/lima-vm/lima/pkg/store/dirnames      [no test files]
?       github.com/lima-vm/lima/pkg/store/filenames     [no test files]
?       github.com/lima-vm/lima/pkg/templateutil        [no test files]
?       github.com/lima-vm/lima/pkg/usrlocalsharelima   [no test files]
?       github.com/lima-vm/lima/pkg/version     [no test files]
FAIL

[iamleot]

After doing a go get -t github.com/lima-vm/lima/pkg/cidata:

$ go test ./...
?       github.com/lima-vm/lima/cmd/limactl     [no test files]
ok      github.com/lima-vm/lima/pkg/cidata      0.012s
ok      github.com/lima-vm/lima/pkg/downloader  0.751s
?       github.com/lima-vm/lima/pkg/guestagent  [no test files]
?       github.com/lima-vm/lima/pkg/guestagent/api      [no test files]
?       github.com/lima-vm/lima/pkg/guestagent/api/client       [no test files]
?       github.com/lima-vm/lima/pkg/guestagent/api/server       [no test files]
ok      github.com/lima-vm/lima/pkg/guestagent/iptables (cached)
ok      github.com/lima-vm/lima/pkg/guestagent/procnettcp       0.004s
?       github.com/lima-vm/lima/pkg/hostagent   [no test files]
?       github.com/lima-vm/lima/pkg/hostagent/api       [no test files]
?       github.com/lima-vm/lima/pkg/hostagent/api/client        [no test files]
?       github.com/lima-vm/lima/pkg/hostagent/api/server        [no test files]
ok      github.com/lima-vm/lima/pkg/hostagent/dns       0.006s
?       github.com/lima-vm/lima/pkg/hostagent/events    [no test files]
?       github.com/lima-vm/lima/pkg/httpclientutil      [no test files]
?       github.com/lima-vm/lima/pkg/httputil    [no test files]
?       github.com/lima-vm/lima/pkg/iso9660util [no test files]
ok      github.com/lima-vm/lima/pkg/limayaml    0.010s
?       github.com/lima-vm/lima/pkg/localpathutil       [no test files]
?       github.com/lima-vm/lima/pkg/lockutil    [no test files]
?       github.com/lima-vm/lima/pkg/logrusutil  [no test files]
--- FAIL: TestUser (0.00s)
    commands_test.go:72: assertion failed: wheel (user.Group string) != root (string)
FAIL
FAIL    github.com/lima-vm/lima/pkg/networks    0.008s
?       github.com/lima-vm/lima/pkg/networks/reconcile  [no test files]
ok      github.com/lima-vm/lima/pkg/osutil      0.003s
ok      github.com/lima-vm/lima/pkg/qemu        0.004s
?       github.com/lima-vm/lima/pkg/qemu/const  [no test files]
?       github.com/lima-vm/lima/pkg/qemu/imgutil        [no test files]
ok      github.com/lima-vm/lima/pkg/sshutil     0.006s
?       github.com/lima-vm/lima/pkg/start       [no test files]
?       github.com/lima-vm/lima/pkg/store       [no test files]
?       github.com/lima-vm/lima/pkg/store/dirnames      [no test files]
?       github.com/lima-vm/lima/pkg/store/filenames     [no test files]
?       github.com/lima-vm/lima/pkg/templateutil        [no test files]
?       github.com/lima-vm/lima/pkg/usrlocalsharelima   [no test files]
?       github.com/lima-vm/lima/pkg/version     [no test files]
FAIL

[afbjorklund]

Thanks for checking, I guess the "wheel" is easy to fix (same as darwin)

        if runtime.GOOS == "darwin" {
                assert.Equal(t, user.Group, "wheel")
        } else {
                assert.Equal(t, user.Group, "root")
        }

Most likely, also FreeBSD.

[iamleot]

Thanks for checking, I guess the "wheel" is easy to fix (same as darwin)

        if runtime.GOOS == "darwin" {
                assert.Equal(t, user.Group, "wheel")
        } else {
                assert.Equal(t, user.Group, "root")
        }

Most likely, also FreeBSD.

Yeah, I will provide a patch about that in a separate PR (and I can confirm that it fixes all the tests then).

[AkihiroSuda]

Thanks