🛠 Fix suggestion list #2143
Merged
🛠 Fix suggestion list #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
RomaricMourgues
commented
May 12, 2022
RomaricMourgues
commented
- Now there is a loader when backend is looking for users
- Show the selector direcclty when putting a single @
- Improve order of results to get the best match first
- Do not refresh list from outdated async backend call
…ora#2101) * linagora#1912 Implement puppeteer and start testing frontend * linagora#1912 Implement puppeteer and start testing frontent part 2 * Update integration-test.yml * Update integration-test.yml * Update integration-test.yml * Fix integration test runner * Improve SPA node provider * Try something else * Fix typo * Try better build of docker node * Add logs * Add logs * install in external directory * Update integration-test.yml * Try with unsafe-perm and yarn * Other command * Fix typo * Une docker onpremise * Typo * linagora#1912 Implement puppeteer and start testing frontend * linagora#1912 Implement puppeteer and start testing frontent part 2 * linagora#1912 Fix integration test * Update config.ts * Add logs * Add logs * Wait for # to ends * Try again to see what is happening * Show page url * Fix static serve issue * Fix create channel button (?) * Show page after plusIcon * Fix integration tests * Add slow mo * Clean code Co-authored-by: Romaric Mourgues <rmourgues@linagora.com>
…ure-files-uploaded-by-user
…d-by-user ⭐️ get uploaded files linagora#2127
RomaricMourgues
added a commit
that referenced
this pull request
May 12, 2022
* #2127 * #2127 * 🌟 #1912 Implement puppeteer and start testing frontend (#2101) * #1912 Implement puppeteer and start testing frontend * #1912 Implement puppeteer and start testing frontent part 2 * Update integration-test.yml * Update integration-test.yml * Update integration-test.yml * Fix integration test runner * Improve SPA node provider * Try something else * Fix typo * Try better build of docker node * Add logs * Add logs * install in external directory * Update integration-test.yml * Try with unsafe-perm and yarn * Other command * Fix typo * Une docker onpremise * Typo * #1912 Implement puppeteer and start testing frontend * #1912 Implement puppeteer and start testing frontent part 2 * #1912 Fix integration test * Update config.ts * Add logs * Add logs * Wait for # to ends * Try again to see what is happening * Show page url * Fix static serve issue * Fix create channel button (?) * Show page after plusIcon * Fix integration tests * Add slow mo * Clean code Co-authored-by: Romaric Mourgues <rmourgues@linagora.com> * Setup new yarn.lock * #2127 * #2127 * Fix suggestion list * Minor improvements * Fix dockerfile error Co-authored-by: romka <8026787@gmail.com> Co-authored-by: Stéphane Vieira <36481167+stephanevieira75@users.noreply.github.com>
github-actions
bot
added
staging:qa
and removed
qa:ready
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.