Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Better Avatars #138

Open
MichaelBailly opened this issue Sep 18, 2020 · 0 comments · Fixed by #137
Open

Better Avatars #138

MichaelBailly opened this issue Sep 18, 2020 · 0 comments · Fixed by #137
Assignees
@MichaelBailly

Comments

@MichaelBailly
Copy link
Contributor

MichaelBailly commented Sep 18, 2020 •
edited
Loading

Initial goal is to improve the speed of inbox emails list.

[ ] remove avatar-list component
[ ] copy avatar edition code to its own module esn.avatar.edition
[ ] adapt SPA to use esn.avatar.edition
[ ] remove old avatar edition code
[ ] move esn-avatar to a John Papa style layout
[ ] add ESN endpoints to tell "give me the people avatar if it got it, otherwise give me nothing. Don't send me an auto-generated avatar
[ ] switch to CSS display for avatars
@MichaelBailly MichaelBailly self-assigned this Sep 18, 2020
MichaelBailly added a commit to MichaelBailly/esn-frontend-common-libs that referenced this issue Sep 18, 2020
@MichaelBailly
linagora#138 Remove useless avatar-list component
56cdea8
MichaelBailly added a commit to MichaelBailly/esn-frontend-common-libs that referenced this issue Sep 18, 2020
@MichaelBailly
linagora#138 copy all module parts related to avatar edition
a56f3d9 
The file is src/frontend/js/modules/avatar/avatar-edition.js
The angular module name is esn.avatar.edition
MichaelBailly added a commit to MichaelBailly/esn-frontend-common-libs that referenced this issue Sep 18, 2020
@MichaelBailly
linagora#138 Move avatar edition tests
11e404e
MichaelBailly added a commit to MichaelBailly/esn-frontend-common-libs that referenced this issue Sep 18, 2020
@MichaelBailly
linagora#138 Remove useless avatar-list component
8a8967a
MichaelBailly added a commit to MichaelBailly/esn-frontend-common-libs that referenced this issue Sep 18, 2020
@MichaelBailly
linagora#138 copy all module parts related to avatar edition
52dca89 
The file is src/frontend/js/modules/avatar/avatar-edition.js
The angular module name is esn.avatar.edition
MichaelBailly added a commit to MichaelBailly/esn-frontend-common-libs that referenced this issue Sep 18, 2020
@MichaelBailly
linagora#138 Move avatar edition tests
48c962c
MichaelBailly added a commit to MichaelBailly/esn-frontend-common-libs that referenced this issue Sep 18, 2020
@MichaelBailly
linagora#138 move esn-avatar to its own files
eb38121 
Also, took the opportunity to:
- embed the src & fallback-src images
- update the image, to use an anonymous avatar instead of a penguin
@itswillta itswillta mentioned this issue Sep 21, 2020
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@MichaelBailly MichaelBailly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New avatars MichaelBailly/esn-frontend-common-libs
1 participant
@MichaelBailly