Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Cleanup permutations #90

Open
jgdumas opened this issue Dec 12, 2017 · 2 comments
Open

Cleanup permutations #90

jgdumas opened this issue Dec 12, 2017 · 2 comments
Labels

Comments

@jgdumas
Copy link
Member

jgdumas commented Dec 12, 2017

blackbox/permutation.h
matrix/ BlasPermutation & MatrixPermutation

Is MatrixPermutation then same as blackbox/permutation.h ?

yuliswe pushed a commit to yuliswe/linbox that referenced this issue Jun 5, 2018
@bdsaunders
Copy link
Member

The answer is yes, MatrixPermutation from matrix/matrix-permutation.h and Permutation from blackbox/permutation.h make the same representation. Meanwhile BlasPermutation is the Lapack style rep used in fflas/ffpack.

Five points:

  1. I don't see a need for two representations of permutations.
  2. I currently have an interest in providing a weighted permutation blackbox.
  3. I want to wrap fflas factorizations in the FIBBs (fast inverse blackbox) framework including the permutations,
  4. It seems to me that permutations belong in blackbox/, reserving matrix/ for sparse and dense representations.
  5. I'm not too happy with the BlasPermutation name (what is it to do with blas?). Perhaps LapackPermutation or simply Permutation can be the name?

I propose to do the following; please comment.

  1. Evolve the current blackbox/permutation.h to a weighted-permutation.h using that representation (having an array P where the permutation sends i to P[i] ). (In part this is a compromise to not throw away this representation altogether.)

  2. Move matrix/matrix-permutation.h to blackbox/permutation.h, holding the lapack style representation and wrapping the fflas/pack perms.

@jgdumas
Copy link
Member Author

jgdumas commented Aug 27, 2018

Sounds good to me !

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants