Fix double-quote handling in release creation workflow #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yang-33
changed the title
Yang-33
changed the title
This was referenced Jan 21, 2025
mokuzon
approved these changes
Jan 23, 2025
Yang-33
added a commit
to line/line-bot-sdk-php
that referenced
this pull request
Jan 23, 2025
This PR escapes the release title’s double quotes and provides the release notes via a file, preventing shell interpretation errors in the gh release create command. Current workflow fails when (1) release title contains `"`: https://github.com/line/line-bot-sdk-java/actions/runs/12886931493/job/35928566569#step:6:3 or (2) PR title contains `"` (e.g. on reverting change, title is `revert "original title"`) (same as line/line-bot-sdk-java#1536)
Yang-33
added a commit
to line/line-bot-sdk-python
that referenced
this pull request
Jan 23, 2025
This PR escapes the release title’s double quotes and provides the release notes via a file, preventing shell interpretation errors in the gh release create command. Current workflow fails when (1) release title contains `"`: https://github.com/line/line-bot-sdk-java/actions/runs/12886931493/job/35928566569#step:6:3 or (2) PR title contains `"` (e.g. on reverting change, title is `revert "original title"`) (same as line/line-bot-sdk-java#1536)
Yang-33
added a commit
to line/line-bot-sdk-nodejs
that referenced
this pull request
Jan 23, 2025
This PR escapes the release title’s double quotes and provides the release notes via a file, preventing shell interpretation errors in the gh release create command. Current workflow fails when (1) release title contains `"`: https://github.com/line/line-bot-sdk-java/actions/runs/12886931493/job/35928566569#step:6:3 or (2) PR title contains `"` (e.g. on reverting change, title is `revert "original title"`) (same as line/line-bot-sdk-java#1536)
Yang-33
added a commit
to line/line-bot-sdk-go
that referenced
this pull request
Jan 23, 2025
This PR escapes the release title’s double quotes and provides the release notes via a file, preventing shell interpretation errors in the gh release create command. Current workflow fails when (1) release title contains `"`: https://github.com/line/line-bot-sdk-java/actions/runs/12886931493/job/35928566569#step:6:3 or (2) PR title contains `"` (e.g. on reverting change, title is `revert "original title"`) (same as line/line-bot-sdk-java#1536)
Yang-33
added a commit
to line/line-bot-sdk-ruby
that referenced
this pull request
Jan 23, 2025
This PR escapes the release title’s double quotes and provides the release notes via a file, preventing shell interpretation errors in the gh release create command. Current workflow fails when (1) release title contains `"`: https://github.com/line/line-bot-sdk-java/actions/runs/12886931493/job/35928566569#step:6:3 or (2) PR title contains `"` (e.g. on reverting change, title is `revert "original title"`) (same as line/line-bot-sdk-java#1536)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR escapes the release title’s double quotes and provides the release notes via a file, preventing shell interpretation errors in the gh release create command.
Current workflow fails when
(1) release title contains
": https://github.com/line/line-bot-sdk-java/actions/runs/12886931493/job/35928566569#step:6:3or (2) PR title contains
"(e.g. on reverting change, title isrevert "original title")