Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Skip create PR when only git submodule is updated #1210

Merged

Conversation

Yang-33
Copy link
Contributor

@Yang-33 Yang-33 commented Mar 28, 2025

Even when only the submodule is updated and the code is not, a PR is created in the bot SDK repository.(like #1208)
If there is no diff in the generated code, I think it's sufficient for Renovate to update the submodule version without creating a PR through the GitHub Actions workflow.

Therefore, this change excludes the submodule from the PR creation conditions and CI failure conditions.

@Yang-33 Yang-33 force-pushed the skip-create-pr-when-only-submodule-is-updated branch from 13edaed to 289de04 Compare March 28, 2025 02:50
Copy link
Contributor

@habara-k habara-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Yang-33 Yang-33 merged commit af4a889 into line:master Mar 31, 2025
7 checks passed
@Yang-33 Yang-33 deleted the skip-create-pr-when-only-submodule-is-updated branch March 31, 2025 02:09
Yang-33 added a commit to line/line-bot-sdk-java that referenced this pull request Mar 31, 2025
Yang-33 added a commit to line/line-bot-sdk-python that referenced this pull request Mar 31, 2025
Yang-33 added a commit to line/line-bot-sdk-php that referenced this pull request Mar 31, 2025
Yang-33 added a commit to line/line-bot-sdk-go that referenced this pull request Mar 31, 2025
Yang-33 added a commit to line/line-bot-sdk-ruby that referenced this pull request Apr 2, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants