-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Skip create PR when only git submodule is updated #1210
Merged
Yang-33
merged 12 commits into
line:master
from
Yang-33:skip-create-pr-when-only-submodule-is-updated
Mar 31, 2025
Merged
Skip create PR when only git submodule is updated #1210
Yang-33
merged 12 commits into
line:master
from
Yang-33:skip-create-pr-when-only-submodule-is-updated
Mar 31, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is not changed (renovate will update)
13edaed
to
289de04
Compare
This was referenced Mar 28, 2025
Closed
habara-k
approved these changes
Mar 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Yang-33
added a commit
to line/line-bot-sdk-java
that referenced
this pull request
Mar 31, 2025
Yang-33
added a commit
to line/line-bot-sdk-python
that referenced
this pull request
Mar 31, 2025
Yang-33
added a commit
to line/line-bot-sdk-php
that referenced
this pull request
Mar 31, 2025
Yang-33
added a commit
to line/line-bot-sdk-go
that referenced
this pull request
Mar 31, 2025
Yang-33
added a commit
to line/line-bot-sdk-ruby
that referenced
this pull request
Apr 2, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even when only the submodule is updated and the code is not, a PR is created in the bot SDK repository.(like #1208)
If there is no diff in the generated code, I think it's sufficient for Renovate to update the submodule version without creating a PR through the GitHub Actions workflow.
Therefore, this change excludes the submodule from the PR creation conditions and CI failure conditions.