add UpdateLiffView for liff.yml #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
habara-k
approved these changes
Oct 24, 2024
This was referenced Oct 24, 2024
habara-k
pushed a commit
to line/line-bot-sdk-nodejs
that referenced
this pull request
Oct 24, 2024
The `view.type` and `view.url` in the request body of [PUT https://api.line.me/liff/v1/apps/{liffId}](https://developers.line.biz/en/reference/liff-server/#update-liff-app) are not required. This PR modifies them to be optional. line/line-openapi#69 Co-authored-by: github-actions <github-actions@github.com>
habara-k
pushed a commit
to line/line-bot-sdk-java
that referenced
this pull request
Oct 24, 2024
The `view.type` and `view.url` in the request body of [PUT https://api.line.me/liff/v1/apps/{liffId}](https://developers.line.biz/en/reference/liff-server/#update-liff-app) are not required. This PR modifies them to be optional. line/line-openapi#69 Co-authored-by: github-actions <github-actions@github.com>
habara-k
pushed a commit
to line/line-bot-sdk-python
that referenced
this pull request
Oct 24, 2024
The `view.type` and `view.url` in the request body of [PUT https://api.line.me/liff/v1/apps/{liffId}](https://developers.line.biz/en/reference/liff-server/#update-liff-app) are not required. This PR modifies them to be optional. line/line-openapi#69 Co-authored-by: github-actions <github-actions@github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
LiffView,view.urlandview.typeare required properties. However, in the LIFF app update API, these properties are not mandatory.ref: https://developers.line.biz/en/reference/liff-server/#update-liff-app
I have defined a new
UpdateLiffViewto solve this issue.