Add FromStr for DynamicColor and static colors
#111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we like this idea, then I'd add tests to the PR. |
This makes it easier to parse them from a string with more concise code and not requiring a separate import of `parse_color`.
waywardmonkeys
force-pushed
the
from_str
branch
from
5bb65c5 to
e5b88b8
Compare
|
This would improve code in Vello's |
nicoburns
approved these changes
Dec 22, 2024
DJMcNab
reviewed
Jan 6, 2025
| fn from_str(s: &str) -> Result<Self, Self::Err> { | ||
| parse_color(s) | ||
| .map(DynamicColor::to_alpha_color) | ||
| .map(AlphaColor::discard_alpha) |
There was a problem hiding this comment.
This one I'm less sure of. If the alpha isn't fully opaque, I'd maybe... expect this to error?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to parse them from a string with more concise code and not requiring a separate import of
parse_color.