Add ACEScg color space #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves linebender#14. Further: - Add Jordan Johnson to AUTHORS list.
This commit fixes issues with the documentation causing Clippy warnings.
This resolves clippy warnings for excessive precision.
tomcur
reviewed
Nov 22, 2024
These rounding errors were caused by rounding to eight decimal places in calculation, then letting clippy round the rest of the way.
Open to later revision, but as Tom points out, CSS color 5 suggests this serialization.
|
This will need some rebasing and support for the new |
tomcur
reviewed
Nov 24, 2024
waywardmonkeys
approved these changes
Nov 25, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves #14. See that issue topic and this Zulip topic for more information, especially on how that matrix was calculated.
I believe this is the first color space added to this crate that is not part of the CSS 4 spec. Because of this, I'm not sure how parsing or serialization should be done for this color space. Guidance would be appreciated, though we could possibly address this in a future PR.