Optionally support serde.
#61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fact that this uses the In particular, crates like |
waywardmonkeys
force-pushed
the
derive-serde
branch
from
2ff892d to
fd08b35
Compare
This adds support for `serde::Deserialize` and `serde::Serialize` using `serde-derive` for `AlphaColor`, `OpaqueColor`, `PremulColor`, `Rgba8`. This does not provide it for `DynamicColor` to avoid dealing with the non-exhaustive `ColorSpaceTag`. It uses `derive` rather than hand-implementing the traits as the latter is very verbose and most things using `serde` will already have enabled the `derive` feature. (This is also true for the other Linebender crates.)
waywardmonkeys
force-pushed
the
derive-serde
branch
from
fd08b35 to
a1f8e14
Compare
raphlinus
approved these changes
Nov 24, 2024
There was a problem hiding this comment.
Looks straightforward, and I agree with the decision not to hand-derive. People who use serde are opting in to that whole thing.
My personal feeling is that if we're annotating these types with serde, then DynamicColor belongs also, but I understand the concern about non-exhaustive and can defer that discussion to later.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
serde::Deserializeandserde::Serializeusingserde-deriveforAlphaColor,OpaqueColor,PremulColor,Rgba8.This does not provide it for
DynamicColorto avoid dealing with the non-exhaustiveColorSpaceTag.It uses
deriverather than hand-implementing the traits as the latter is very verbose and most things usingserdewill already have enabled thederivefeature. (This is also true for the other Linebender crates.)