-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add BLACK
, WHITE
, TRANSPARENT
constants to color types.
#64
Conversation
These are useful values to have without having to go to the palette. Additionally, this allows for getting the correct value for the colorspace for white without having to go through a conversion. Fixes #63.
This is one of the changes that will help make using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks! I agree this is useful to have.
@@ -15,12 +15,20 @@ You can find its changes [documented below](#010-2024-11-20). | |||
|
|||
This release has an [MSRV][] of 1.82. | |||
|
|||
### Added | |||
|
|||
* Add `BLACK`, `WHITE`, and `TRANSPARENT` constants to the color types. ([#64][] by [@waywardmonkeys][]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth noting that this is a breaking change?
It feels like there's an interesting thing here, that ideally we'd have different definitions of breaking for creators of custom colorspaces and users of the crate - creators of custom colorspaces are so rare that kind of mad.
I guess color would probably be a good use-case for the semver-trick.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There will be some other breaking changes as well. But I guess we could call out that ColorSpace
must have a WHITE_COMPONENTS
const now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that is the breaking change. Our standards for marking breaking changes aren't very developed.
These are useful values to have without having to go to the palette. Additionally, this allows for getting the correct value for the colorspace for white without having to go through a conversion.
Fixes #63.