Add PremulRgba8, Rgba8::to_u32
#66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waywardmonkeys
force-pushed
the
premulrgb8
branch
2 times, most recently
from
e2b36a3 to
1b9230b
Compare
waywardmonkeys
changed the title
PremulRgb8a, Rgba8::to_u32PremulRgba8, Rgba8::to_u32
raphlinus
approved these changes
Nov 24, 2024
waywardmonkeys
force-pushed
the
premulrgb8
branch
2 times, most recently
from
69c004d to
6a51843
Compare
Packing a `PremulColor` to 8 bit channels is a common operation and is done in Vello, so we now have support for a `PremulRgb8a` and some `to_u32` operations as well.
waywardmonkeys
force-pushed
the
premulrgb8
branch
from
6a51843 to
45e459b
Compare
DJMcNab
reviewed
Nov 26, 2024
| /// Returns the color as a packed value, with `r` as the most significant byte and | ||
| /// `a` the least. | ||
| #[must_use] | ||
| pub const fn to_u32(self) -> u32 { |
There was a problem hiding this comment.
IWBN to have the mirroring from_u32.
DJMcNab
reviewed
Nov 26, 2024
| /// `a` the least. | ||
| #[must_use] | ||
| pub const fn to_u32(self) -> u32 { | ||
| ((self.r as u32) << 24) | ((self.g as u32) << 16) | ((self.b as u32) << 8) | self.a as u32 |
There was a problem hiding this comment.
Should this use from_be_bytes instead? That is also const.
waywardmonkeys
added a commit
to waywardmonkeys/color
that referenced
this pull request
Nov 26, 2024
Also, add a short sanity check test. Based on feedback from @DJMcNab in PR linebender#66.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packing a
PremulColorto 8 bit channels is a common operation and is done in Vello, so we now have support for aPremulRgb8aand someto_u32operations as well.