Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Derive PartialEq by hand to avoid ColorSpace: PartialEq bound #86

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Derive PartialEq by hand to avoid ColorSpace: PartialEq bound #86

merged 1 commit into from
Dec 10, 2024

Conversation

waywardmonkeys
Copy link
Collaborator

There's no need for each ColorSpace to have to impl PartialEq since they're zero-sized types.

@waywardmonkeys
Derive PartialEq by hand to avoid ColorSpace: PartialEq bound
7ef7aea 
There's no need for each `ColorSpace` to have to impl `PartialEq`
since they're zero-sized types.
raphlinus
raphlinus approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@raphlinus raphlinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup I think this is fine. I note it doesn't impl for other colorspaces, but I think it's good for that to be a type error rather than us trying to solve the philosophical question of whether colors in different colorspaces can be equal.

@waywardmonkeys waywardmonkeys added this pull request to the merge queue Dec 10, 2024
Merged via the queue into linebender:main with commit 500f090 Dec 10, 2024
15 checks passed
@waywardmonkeys waywardmonkeys deleted the fix-partialeq branch December 10, 2024 05:18
@waywardmonkeys waywardmonkeys added this to the 0.2.0 milestone Dec 17, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@raphlinus raphlinus raphlinus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@waywardmonkeys @raphlinus