Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move docs on Main Types to the top #97

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

nicoburns
Copy link
Contributor

@nicoburns nicoburns commented Dec 16, 2024

Moves the "Main types" section above the "Scope and goals" section in the lib.rs docs.

Justification: I think the documentation on "what are the main types in this crate" / "how do I use this crate" ought to be front and center. Whereas the "background" on scope and goal is more secondary. The "Main Types" section is also quite a bit shorter than the "Scope and goals" section, so it means both fit "above the fold".

More concretely, I was reading the docs and trying to work out which type(s) could be considered the primary/default color representation(s). And it took me quite a bit of time to find it even though there was already a section explaining it.

@nicoburns nicoburns added the documentation Improvements or additions to documentation label Dec 16, 2024
Signed-off-by: Nico Burns <nico@nicoburns.com>
Copy link
Collaborator

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this. You'll have to fix the readme check before landing this.

Signed-off-by: Nico Burns <nico@nicoburns.com>
@nicoburns nicoburns added this pull request to the merge queue Dec 16, 2024
Merged via the queue into linebender:main with commit 76f412c Dec 16, 2024
15 checks passed
@nicoburns nicoburns deleted the move-type-docs-up branch December 16, 2024 02:52
@waywardmonkeys waywardmonkeys added this to the 0.2.0 milestone Dec 17, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants