[mac] Adopt new save/open API #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements the new save/open (#1068) API on macOS. The implementation here is slightly different; Cocoa uses the idea of 'blocks' (a c extension for callbacks) in most of their async API, so we don't need to to manually defer the work.
jneem
approved these changes
Oct 20, 2020
| let token = FileDialogToken::next(); | ||
| let self_clone = self.clone(); | ||
| unsafe { | ||
| let panel = dialog::build_panel(FileDialogType::Save, options); |
There was a problem hiding this comment.
Looks like except for FileDialogType::Save this is identical to open_file?
There was a problem hiding this comment.
also different is the method we call on the handler inside the block. I could probably come up with some way to share this code more but I'm not sure it's worth the typing.
There was a problem hiding this comment.
(okay fine I rewrote it to share an implementation 😛)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the new save/open (#1068) API on macOS.
The implementation here is slightly different; Cocoa uses the idea
of 'blocks' (a c extension for callbacks) in most of their async API,
so we don't need to to manually defer the work.