Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

WidgetPod: change not laid out panic to warning #1441

Merged
merged 2 commits into from
Dec 2, 2020
Merged

WidgetPod: change not laid out panic to warning #1441

merged 2 commits into from
Dec 2, 2020

Conversation

maan2003
Copy link
Collaborator

@maan2003 maan2003 commented Dec 2, 2020

This changes debug_panic about widgets recieving events without being laid, back to warning. This was introduced in 8715757.

cmyr
cmyr approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I don't think we need to keep crashing all the time until we've figured out what our actual invariants are. 👍

@cmyr cmyr merged commit 63d2392 into linebender:master Dec 2, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cmyr cmyr cmyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maan2003 @cmyr