Add rounding to the size given to BoxConstraints::constrain. #734
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of the pixel grid work started in #669. Adding
Size::expand
toBoxConstraints::constrain
seems to go a long way in solving this. It solves the issue forLabel
but also in more subtle places likeSwitch
which depend on theme variables by doing things like this:Doing it in
BoxConstraints::constrain
will also help with custom widgets that users might unknowingly make fractional.I reviewed all current widgets in druid and this change doesn't seem to have any other effects at this point.