Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Limit Color::to_rgba_string precision #117

Merged
merged 3 commits into from
May 10, 2021
Merged

Limit Color::to_rgba_string precision #117

merged 3 commits into from
May 10, 2021

Conversation

madig
Copy link
Collaborator

@madig madig commented May 10, 2021

Closes #115.

Serialization precision is limited, deserialization precision is not.

@github-actions
Copy link

🗜 Bloat check ⚖️

Comparing d3966d3 against 1c7e347

target old size new size difference
target/release/examples/open_ufo 1.69 MB 1.69 MB -864 Bytes (-0.05%)
target/debug/examples/open_ufo 7.08 MB 7.07 MB -440 Bytes (-0.01%)

@linebender linebender deleted a comment from github-actions bot May 10, 2021
cmyr
cmyr approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! one comment inline, which I would encourage you to be skeptical about. 🤷

src/glyph/serialize.rs Outdated Show resolved Hide resolved
cmyr
cmyr approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢💨

@github-actions
Copy link

🗜 Bloat check ⚖️

Comparing bf6a262 against 1c7e347

target old size new size difference
target/release/examples/open_ufo 1.69 MB 1.69 MB -160 Bytes (-0.01%)
target/debug/examples/open_ufo 7.08 MB 7.07 MB -648 Bytes (-0.01%)

@madig madig merged commit e02654c into master May 10, 2021
@madig madig deleted the limit-color-string-precision branch May 10, 2021 21:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cmyr cmyr cmyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Color::to_rgba_string: Add precision parameter?
2 participants
@madig @cmyr