Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Overwrite meta.creator on save #134

Merged
merged 1 commit into from
May 14, 2021
Merged

Overwrite meta.creator on save #134

merged 1 commit into from
May 14, 2021

Conversation

cmyr
Copy link
Member

@cmyr cmyr commented May 13, 2021

@github-actions
Copy link

🗜 Bloat check ⚖️

Comparing ef411c8 against 195dea0

target old size new size difference
target/release/examples/open_ufo 1.71 MB 1.71 MB ---
target/debug/examples/open_ufo 7.14 MB 7.14 MB 384 Bytes (0.01%)

@madig
Copy link
Collaborator

madig commented May 13, 2021

Wait, what does the if-else do exactly?

@cmyr
Copy link
Member Author

cmyr commented May 13, 2021

yes it's maybe useless? if we are already set as the creator, then it just uses the existing metadata, otherwise it creates new metadata with us as the creator.

madig
madig approved these changes May 13, 2021
View reviewed changes
Copy link
Collaborator

@madig madig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, ok.

@cmyr cmyr merged commit 292514d into master May 14, 2021
@cmyr cmyr deleted the always-set-creator branch May 14, 2021 13:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@madig madig madig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unconditionally overwrite meta.creator on writing
2 participants
@cmyr @madig