Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use f64 instead of f32 everywhere #184

Merged
merged 2 commits into from
Sep 28, 2021
Merged

Use f64 instead of f32 everywhere #184

merged 2 commits into from
Sep 28, 2021

Conversation

madig
Copy link
Collaborator

@madig madig commented Sep 27, 2021

Python floats as used by ufoLib are implicitly f64.

Closes #164.

Maybe we need to change i32 to i64 as well at some point.

Python numbers as used by ufoLib are implicitly f64.
@madig madig marked this pull request as draft September 28, 2021 07:59
@linebender linebender deleted a comment from github-actions bot Sep 28, 2021
@github-actions
Copy link

🗜 Bloat check ⚖️

Comparing 63de010 against a4a2b13

target old size new size difference
target/release/examples/load_save 1.8 MB 1.79 MB -17.66 KB (-0.96%)
target/debug/examples/load_save 8.35 MB 8.3 MB -55.22 KB (-0.65%)

@madig madig marked this pull request as ready for review September 28, 2021 16:03
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use f64 for floating point numbers
2 participants