Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use LayerInfo struct to deserialize layerinfo.plist #214

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

madig
Copy link
Collaborator

@madig madig commented Dec 17, 2021

The new plist crate can hande nested Values when deserializing, so we can now cut some code and an error.

Not sure yet what to do about serialization, because we have to do some post-processing.

@madig madig mentioned this pull request Dec 17, 2021
4 tasks
@github-actions
Copy link

🗜 Bloat check ⚖️

Comparing c403319 against 7c86886

target old size new size difference
target/release/examples/load_save 1.88 MB 1.9 MB 20.16 KB (1.05%)
target/debug/examples/load_save 8.45 MB 8.55 MB 104.13 KB (1.20%)

Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, happy to delete some code! Some notes inline but nothing blocking, feel free to merge when you're happy. :)

src/layer.rs Outdated Show resolved Hide resolved
src/layer.rs Outdated Show resolved Hide resolved
Base automatically changed from error-tweaks to master December 17, 2021 19:55
@madig madig force-pushed the use-serde-for-layerinfo branch from b7d539b to 89e9c31 Compare December 17, 2021 20:48
@madig madig force-pushed the use-serde-for-layerinfo branch from 89e9c31 to 32dc66d Compare December 17, 2021 20:53
@linebender linebender deleted a comment from github-actions bot Dec 17, 2021
@github-actions
Copy link

🗜 Bloat check ⚖️

Comparing 4d6c8d3 against e8ac638

target old size new size difference
target/release/examples/load_save 1.88 MB 1.9 MB 20.41 KB (1.06%)
target/debug/examples/load_save 8.45 MB 8.55 MB 106.15 KB (1.23%)

@madig madig merged commit 5f0cc9c into master Dec 17, 2021
@madig madig deleted the use-serde-for-layerinfo branch December 17, 2021 21:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants