Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Validate some structures up front #244

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Validate some structures up front #244

merged 1 commit into from
Jan 11, 2022

Conversation

madig
Copy link
Collaborator

@madig madig commented Jan 11, 2022

Closes #213.

Base automatically changed from harden-image to master January 11, 2022 14:48
@github-actions
Copy link

🗜 Bloat check ⚖️

Comparing 544be44 against c523ffe

target old size new size difference
target/release/examples/load_save 1.9 MB 1.9 MB 144 Bytes (0.01%)
target/debug/examples/load_save 8.58 MB 8.58 MB 2.43 KB (0.03%)

cmyr
cmyr approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like some nice cleanup, thanks!

@madig madig merged commit ca778ba into master Jan 11, 2022
@madig madig deleted the validate-some-up-front branch January 11, 2022 18:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cmyr cmyr cmyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Font::save: run validate_groups before touching the filesystem
2 participants
@madig @cmyr