Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix DesignSpaceDocument lib serialization #339

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

madig
Copy link
Collaborator

@madig madig commented Dec 29, 2023

TODO:

  • Actually fix serialization
  • Should serialization also remove the "@" character from field names that serves only as a hint for quick-xml?

Closes #338.

@madig madig force-pushed the fix-lib-serialization branch from 07ba676 to 0ff3fb7 Compare December 29, 2023 20:53
@madig
Copy link
Collaborator Author

madig commented Dec 30, 2023

I now realize that the serializer is a special-case implementation for quick-xml. Should the XML serialization stuff be kept in a separate serializer maybe to not interfere with lib serialization?

@RickyDaMa
Copy link
Collaborator

Should the XML serialization stuff be kept in a separate serializer maybe to not interfere with lib serialization?

Yeah I have a feeling to have good XML & JSON support we'll probably need to separate the implementations, given how serde annotations etc. are used by quick-xml. Just a hunch, I haven't looked into this myself. It's that or we may have to bully serde into using different (de)serialization logic depending on the format (which AFAIK it's not really supposed to do)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serialization of Designspaces mangles lib
2 participants