-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Simplify Glyph #93
Simplify Glyph #93
Conversation
I am now looking at de-Option-ing the libs of Anchor, Guideline, Contour, ContourPoint and Component. There, we have the added headache of identifiers. The |
Is the option in these types a big problem, ergonomics-wise? I think that creating an identifier on access is reasonable, it's sort of like 'copy on write' semantics. |
Since there doesn't seem to be much code accessing those libs, I can't say, it is very slightly annoying when you have to, though. Maybe I'll leave it for now... I'll have to think about this more. |
I wonder why a release build is bigger now 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One little note, otherwise this looks good to me!
Closes #92.
I'm keeping
Outline
around for only-once checking. Maybe... I can cut down the builders again and get the only-once logic back into the glif parser...