Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: update to vello 0.4 #49

Merged
merged 14 commits into from
Jan 30, 2025
Merged

chore: update to vello 0.4 #49

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
8881dee
chore: update to vello 0.4
simbleau Jan 27, 2025
671bdda
build: use transparent instead
simbleau Jan 27, 2025
469edf0
fix: changelog and msrv
simbleau Jan 27, 2025
8de2250
fix: msrv
simbleau Jan 27, 2025
b7785e6
docs: adjust msrv
simbleau Jan 27, 2025
b1a301c
fix: lints
simbleau Jan 27, 2025
8c92202
fix: clippy lints
simbleau Jan 27, 2025
766c6db
fix: clippy lint
simbleau Jan 27, 2025
b47394b
build: revert this lint
simbleau Jan 27, 2025
58beeb5
fix: missing #49
simbleau Jan 27, 2025
d151ebe
fix: syntax on external link
simbleau Jan 27, 2025
538d84e
build: unstage double quotes
simbleau Jan 27, 2025
e170b42
fix: satisfy clippy
simbleau Jan 27, 2025
c0dfedd
fix: add back unused crate deps
simbleau Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,11 @@ env:
# If the compilation fails, then the version specified here needs to be bumped up to reality.
# Be sure to also update the rust-version property in the workspace Cargo.toml file,
# plus all the README.md files of the affected packages.
RUST_MIN_VER: "1.75"
RUST_MIN_VER: "1.82"
# List of packages that will be checked with the minimum supported Rust version.
# This should be limited to packages that are intended for publishing.
RUST_MIN_VER_PKGS: "-p velato"


# Rationale
#
# We don't run clippy with --all-targets because then even --lib and --bins are compiled with
Expand Down Expand Up @@ -152,13 +151,13 @@ jobs:
os: [windows-latest, macos-latest, ubuntu-latest]
include:
- os: ubuntu-latest
gpu: 'yes'
gpu: "yes"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change all of these? Having them differ from all of the other Linebender CI tasks would be annoying. We can change them everywhere, but would want to know why it is needed here.

Copy link
Member Author

@simbleau simbleau Jan 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These got autoformatted since the top of the file uses " instead of '
e.g. RUST_MIN_VER: "1.82"

I think whatever vscode extension I have wanted to make it consistent.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just don't stage those changes in the PR then, please.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

- os: macos-latest
gpu: 'yes'
gpu: "yes"
- os: windows-latest
# TODO: The windows runners theoretically have CPU fallback for GPUs, but
# this failed in initial testing
gpu: 'no'
gpu: "no"
steps:
- uses: actions/checkout@v4

Expand Down Expand Up @@ -244,7 +243,7 @@ jobs:
run: cargo apk check -p with_winit --lib
env:
# This is a bit of a hack, but cargo apk doesn't seem to allow customising this
RUSTFLAGS: '-D warnings'
RUSTFLAGS: "-D warnings"

check-msrv:
name: cargo check (msrv)
Expand Down Expand Up @@ -322,7 +321,7 @@ jobs:
- name: cargo doc
run: cargo doc --workspace --locked --all-features --no-deps --document-private-items
env:
RUSTDOCFLAGS: '--cfg docsrs -D warnings'
RUSTDOCFLAGS: "--cfg docsrs -D warnings"

# If this fails, consider changing your text or adding something to .typos.toml.
typos:
Expand Down
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@ Subheadings to categorize changes are `added, changed, deprecated, removed, fixe

## [Unreleased]

This release has an [MSRV][] of 1.75.
This release has an [MSRV][] of 1.82.

### Changed

- Updated to `vello` 0.4 ([#49][] by [@simbleau][]).

## [0.4.0] - 2024-11-21

Expand Down
Loading