vello_toy: Color lines according to their winding sign #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#845 removed line-tile intersections from the debug rendering, as these are no longer present in the internal representation. However, that also removed a way to see whether lines are directed upwards or downwards, which is important to understand their effect on winding. This proposes coloring the lines according to their orientation: lines oriented upwards add to winding and are colored green. Lines oriented downwards subtract from winding and are colored red. Horizontal lines don't affect winding, and will with future changes likely not generate any tiles at all. These are colored grey.
LaurenzV
approved these changes
Mar 11, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#845 removed line-tile intersections from the debug rendering, as these are no longer present in the internal representation.
However, that also removed a way to see whether lines are directed upwards or downwards, which is important to understand their effect on winding.
This proposes coloring the lines according to their orientation: lines oriented upwards add to winding and are colored green. Lines oriented downwards subtract from winding and are colored red. Horizontal lines don't affect winding, and will with future changes likely not generate any tiles at all. These are colored grey.
An example of what that looks like:
cargo run --bin debug -- --path "M 5 5 L 40 23 L 20 43.5 L 1 43.5 Z" --stages ls,ta