fix: nested macros used in useLingui in arrow functions #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
andrii-bodnar
force-pushed
the
fix/use-lingui-nested-in-arrow
branch
from
df68677 to
c26dc16
Compare
andrii-bodnar
approved these changes
Dec 23, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: lingui/js-lingui#2095 (comment)
It turned out that
ArrowFunctionExpressionfalls intoExpressioncategory as well, unlike the regular Function, that caused nested macros such apluralto be processed before the outer macro is processed and get a wrong result.