adjust atol value for mini_qwen2_vl
FP32 in test_mini_model_multimodal
#563
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
test_mini_model_multimodal
has 2 test models: mini_mllama and mini_qwen2_vl. On XPU, mini_mllama cases pass but mini_qwen2_vl cases fail. In the 2 failed cases: one fails at 1e-2 decimal point, which we need to fix; but the other fails at 1e-6 decimal point, which we suspect that the atol is set too strict for non-cuda hardware accelerators as can be seen below:This PR tries to fix this. What do you guys think?
make test
to ensure correctnessmake checkstyle
to ensure code stylemake test-convergence
to ensure convergence