Support generating locals that reference generated class types (#146) #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…din#146) We have had support for the const-class operation, but it was only possible to fill a local with the value of a Class object you could reference in the geneeration context. This meant that it was not possible to generate a reference to a generated class, as it did not exist in the class loader until after the generation was finished and the new class loader could be used. The real issue here is the restriction of the loadConstant() method, which requires an actual Class object. This class object gets turned into a string internally for code generation, and so we don't actually need a real class to fill the variable value correctly. Using a TypeId will still get converted to a ConstantInsn under the hood, and the value will be assigned correctly.
drewhannay
approved these changes
Nov 27, 2019
chao2zhang
approved these changes
Nov 27, 2019
kkoser
added a commit
to kkoser/dexmaker
that referenced
this pull request
Dec 2, 2019
kkoser
added a commit
to kkoser/dexmaker
that referenced
this pull request
Dec 2, 2019
kkoser
added a commit
to kkoser/dexmaker
that referenced
this pull request
Dec 2, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have had support for the const-class operation, but it was only possible to
fill a local with the value of a Class object you could reference in the geneeration
context. This meant that it was not possible to generate a reference to a generated
class, as it did not exist in the class loader until after the generation was finished
and the new class loader could be used.
The real issue here is the restriction of the loadConstant() method, which requires an
actual Class object. This class object gets turned into a string internally for code
generation, and so we don't actually need a real class to fill the variable value
correctly. Using a TypeId will still get converted to a ConstantInsn under the hood,
and the value will be assigned correctly.