-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add include/exclude filters for pod names #121
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@linki let me know what you think about this. |
linki
requested changes
May 9, 2019
Hi @dansimone, thanks a lot for your PR and sorry for the late response (I was travelling). Looks pretty good to me, I'm happy to merge. |
linki
approved these changes
May 19, 2019
Thanks @dansimone 🎉 |
Thanks @linki, just circling back to this now. Your comments sound great, and thanks for making those changes! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds parameters that allow pod to be filtered in/out by pod name. This is a useful feature because some existing Kubernetes applications (the one I work on is an example) don't have the necessary labels that are required to make use of the existing chaoskube label selector filtering. So for those users, this just allows them to provide a simple regex pattern for pod names to include and to exclude.
Also includes: