Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add include/exclude filters for pod names #121

Merged
merged 6 commits into from
May 20, 2019

Conversation

dansimone
Copy link
Contributor

This PR adds parameters that allow pod to be filtered in/out by pod name. This is a useful feature because some existing Kubernetes applications (the one I work on is an example) don't have the necessary labels that are required to make use of the existing chaoskube label selector filtering. So for those users, this just allows them to provide a simple regex pattern for pod names to include and to exclude.

Also includes:

  • README updates to indicate the new usage
  • Necessary test updates, including verifying the new capability in TestCandidates().

@dansimone
Copy link
Contributor Author

@linki let me know what you think about this.

chaoskube/chaoskube.go Outdated Show resolved Hide resolved
chaoskube/chaoskube_test.go Outdated Show resolved Hide resolved
chaoskube/chaoskube.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@linki
Copy link
Owner

linki commented May 9, 2019

Hi @dansimone,

thanks a lot for your PR and sorry for the late response (I was travelling).

Looks pretty good to me, I'm happy to merge.
I just added a couple of minor remarks. Let me know what you think about them.

@linki linki merged commit a6261ac into linki:master May 20, 2019
@linki
Copy link
Owner

linki commented May 20, 2019

Thanks @dansimone 🎉

@dansimone
Copy link
Contributor Author

Thanks @linki, just circling back to this now. Your comments sound great, and thanks for making those changes!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants