New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refining array model #153

Merged

cmungall merged 8 commits into main from refining-array-model

Apr 14, 2023

Member

cmungall commented Mar 31, 2023

refinements to array metamodel
test example from @rly

cmungall added 2 commits

March 31, 2023 12:55


          refinements to array metamodel

fdbcf0d


          test example from @rly

a799b8b

cmungall requested a review from rly

March 31, 2023 21:22

Contributor

rly commented Apr 4, 2023

rly reviewed

View reviewed changes

linkml_model/model/schema/array.yaml Outdated Show resolved Hide resolved

rly reviewed

View reviewed changes

linkml_model/model/schema/array.yaml

+                      meaning: gom:columnMajorArray
+                      description: >-
+                        An array layout option in which the elements in each row are stored in consecutive positions,
+                        or any generalization thereof to dimensionality greater than 2

Contributor

rly Apr 14, 2023

Suggested change

      
                      or any generalization thereof to dimensionality greater than 2
          
                      or any generalization thereof to dimensionality greater than 2
          
                    aliases:
          
                      - F order

rly reviewed

View reviewed changes

linkml_model/model/schema/array.yaml Show resolved Hide resolved

rly reviewed

View reviewed changes

linkml_model/model/schema/array.yaml Outdated

+                    COLUMN_MAJOR_ARRAY_ORDER:
+                      meaning: gom:columnMajorArray
+                      description: >-
+                        An array layout option in which the elements in each row are stored in consecutive positions,

Contributor

rly Apr 14, 2023

Suggested change

      
                      An array layout option in which the elements in each row are stored in consecutive positions,
          
                      An array layout option in which the elements in each column are stored in consecutive positions,

cmungall added 3 commits

April 14, 2023 15:29


          remove redundant assertion

a901bb7


          Update array.yaml

e2a1235


          Update array.yaml

778d692

rly reviewed

View reviewed changes

tests/input/examples/schema_definition-array.yaml Outdated Show resolved Hide resolved


          Update schema_definition-array.yaml

54d5cd1

rly reviewed

View reviewed changes

tests/input/examples/schema_definition-array.yaml Show resolved Hide resolved

rly approved these changes

View reviewed changes

cmungall and others added 2 commits

April 14, 2023 16:20


          Update linkml_model/model/schema/array.yaml

Co-authored-by: Ryan Ly <rly@lbl.gov>


          Update tests/input/examples/schema_definition-array.yaml

6690c03

Co-authored-by: Ryan Ly <rly@lbl.gov>

cmungall merged commit 356a065 into main

cmungall deleted the refining-array-model branch

April 14, 2023 23:23

rly mentioned this pull request

Generate basic Pydantic model for data arrays linkml/linkml#1397

Merged

rly mentioned this pull request

How does the hdmf-common namespace work? NeurodataWithoutBorders/nwb-schema#540

Open

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet