Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix repository name in release workflow #169

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Conversation

pkalita-lbl
Copy link
Contributor

No description provided.

@pkalita-lbl pkalita-lbl requested a review from cmungall September 1, 2023 21:59
@pkalita-lbl
Copy link
Contributor Author

🤦🏻

It looks like now that we've released v1.6.0 we have more releases than this request gets in one shot. We could probably kick the can down the road a bit by adding adding a per_page query parameter. Or we could make that method smarter by following pagination links until it finds what it's looking for or until it runs out of pages.

@pkalita-lbl
Copy link
Contributor Author

Since I'm going to be out of the office for a bit I've got ahead and kicked the can (i.e. using the per_page parameter) so that I'm not leaving this in a broken state. I can revisit it when I'm back if we think a more robust solution is needed.

@pkalita-lbl pkalita-lbl merged commit 0bb8b07 into main Sep 13, 2023
@pkalita-lbl pkalita-lbl deleted the fix-release-workflow branch September 13, 2023 16:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants