Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Adding recommended field #26

Merged
merged 1 commit into from
Jun 26, 2021
Merged

Adding recommended field #26

merged 1 commit into from
Jun 26, 2021

Conversation

cmungall
Copy link
Member

@cmungall cmungall commented Jun 18, 2021 •
edited
Loading

@cmungall cmungall requested review from hsolbrig and jiaola June 18, 2021 18:59
hsolbrig
hsolbrig approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@hsolbrig hsolbrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We may want to disallow "recommended: true / required: true"

@cmungall cmungall merged commit 419e3f6 into main Jun 26, 2021
@cmungall cmungall deleted the linkml-issue-177 branch June 26, 2021 00:10
@cmungall cmungall mentioned this pull request Jul 5, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hsolbrig hsolbrig hsolbrig approved these changes

@jiaola jiaola Awaiting requested review from jiaola

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Similar to linkml:required, could we have a linkml:recommended boolean?
2 participants
@cmungall @hsolbrig