Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[feat] templates: add Flatcar template #394

Merged
merged 5 commits into from
Jul 29, 2024

Conversation

tormath1
Copy link
Contributor

@tormath1 tormath1 commented Jul 5, 2024

It is based on vpcless.

What this PR does / why we need it: This PR brings Flatcar templates to CAPL

Special notes for your reviewer:

  • For now it is based on vpcless - using kubeadm default template makes the metadata server returning 500 Internal error
  • Because the user-data is limited in size, I can't setup the Kubernetes sysext auto-update on Kubernetes patch releases
 $ kubectl --kubeconfig=./${CLUSTER_NAME}.kubeconfig get nodes -w
NAME                               STATUS   ROLES           AGE     VERSION
test-cluster-control-plane-fb9xm   Ready    control-plane   6m22s   v1.29.5
test-cluster-md-0-ccq4p-gdcn9      Ready    <none>          2m16s   v1.29.5
test-cluster-md-0-ccq4p-lsjtj      Ready    <none>          3m17s   v1.29.5
test-cluster-md-0-ccq4p-lxpwp      Ready    <none>          2m14s   v1.29.5
$ make e2etest E2E_SELECTOR='flatcar' E2E_FLAGS='--assert-timeout 10m0s'
...
--- PASS: chainsaw (0.00s)
    --- PASS: chainsaw/flatcar-capl-cluster (463.58s)
PASS
Tests Summary...
- Passed  tests 1
- Failed  tests 0
- Skipped tests 0
Done.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@eljohnson92 eljohnson92 marked this pull request as ready for review July 7, 2024 22:40
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 64.65%. Comparing base (e83dc0c) to head (641aba9).

Files Patch % Lines
controller/linodemachine_controller.go 25.00% 9 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #394      +/-   ##
==========================================
- Coverage   64.80%   64.65%   -0.15%     
==========================================
  Files          68       68              
  Lines        3506     3517      +11     
==========================================
+ Hits         2272     2274       +2     
- Misses       1054     1061       +7     
- Partials      180      182       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tormath1 tormath1 force-pushed the tormath1/flatcar branch from cdc30f6 to e90a7a6 Compare July 9, 2024 13:54
@tormath1 tormath1 changed the title [wip] [feat] templates: add Flatcar template [feat] templates: add Flatcar template Jul 9, 2024
@tormath1 tormath1 force-pushed the tormath1/flatcar branch 5 times, most recently from 8cb29aa to 697ec51 Compare July 10, 2024 12:46
@tormath1 tormath1 force-pushed the tormath1/flatcar branch 2 times, most recently from 4e6694f to 3d3d91f Compare July 18, 2024 09:53
@tormath1
Copy link
Contributor Author

ready for final review

@tormath1 tormath1 force-pushed the tormath1/flatcar branch 2 times, most recently from 7f9f24c to c166b6b Compare July 29, 2024 15:13
@tormath1
Copy link
Contributor Author

rebased on main and moved the Configuration changes from v1alpha1 to to v1alpha2

tormath1 added 2 commits July 29, 2024 17:17
This field can be used to override the default configuration of the
instance.

Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
tormath1 added 3 commits July 29, 2024 17:22
It is based on vpcless.

Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
This test will upload a Flatcar image and deploy a 2 nodes cluster

Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@eljohnson92 eljohnson92 merged commit 0a32a1f into linode:main Jul 29, 2024
7 of 10 checks passed
@tormath1 tormath1 deleted the tormath1/flatcar branch July 30, 2024 07:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants