-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[feat] templates: add Flatcar template #394
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
==========================================
- Coverage 64.80% 64.65% -0.15%
==========================================
Files 68 68
Lines 3506 3517 +11
==========================================
+ Hits 2272 2274 +2
- Misses 1054 1061 +7
- Partials 180 182 +2 ☔ View full report in Codecov by Sentry. |
tormath1
force-pushed
the
tormath1/flatcar
branch
from
July 9, 2024 13:54
cdc30f6
to
e90a7a6
Compare
tormath1
changed the title
[wip] [feat] templates: add Flatcar template
[feat] templates: add Flatcar template
Jul 9, 2024
eljohnson92
reviewed
Jul 9, 2024
eljohnson92
reviewed
Jul 9, 2024
tormath1
force-pushed
the
tormath1/flatcar
branch
5 times, most recently
from
July 10, 2024 12:46
8cb29aa
to
697ec51
Compare
eljohnson92
reviewed
Jul 10, 2024
eljohnson92
reviewed
Jul 10, 2024
eljohnson92
reviewed
Jul 10, 2024
eljohnson92
reviewed
Jul 10, 2024
eljohnson92
reviewed
Jul 10, 2024
eljohnson92
reviewed
Jul 10, 2024
tormath1
force-pushed
the
tormath1/flatcar
branch
2 times, most recently
from
July 18, 2024 09:53
4e6694f
to
3d3d91f
Compare
ready for final review |
tormath1
force-pushed
the
tormath1/flatcar
branch
2 times, most recently
from
July 29, 2024 15:13
7f9f24c
to
c166b6b
Compare
rebased on main and moved the |
This field can be used to override the default configuration of the instance. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
tormath1
force-pushed
the
tormath1/flatcar
branch
from
July 29, 2024 15:17
c166b6b
to
cafdcf9
Compare
It is based on vpcless. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
This test will upload a Flatcar image and deploy a 2 nodes cluster Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
tormath1
force-pushed
the
tormath1/flatcar
branch
from
July 29, 2024 15:22
cafdcf9
to
641aba9
Compare
eljohnson92
approved these changes
Jul 29, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is based on vpcless.
What this PR does / why we need it: This PR brings Flatcar templates to CAPL
Special notes for your reviewer:
vpcless
- usingkubeadm
default template makes the metadata server returning 500 Internal errorTODOs: