Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[deps] linodego update from 1.36.2 to 1.37.0 #417

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

unnatiagg
Copy link
Contributor

@unnatiagg unnatiagg commented Jul 19, 2024

**In the latest version of Linodego The 'Cluster' field has been deprecated in favor of the 'Region' field for ObjectStorageBucket. To maintain backward compatibility linodego still supports the Cluster Field, but we are upgrading our code to shift from 'Cluster' field to 'Region' field entirely. **:

**Please refer this link to understand the upgrade in the linodego api. All the APIs now support clusterOrRegionID instead of just a ClusterID in Linodego. **

**We plan to do a two fold update for this change in CAPL:

  1. Step 1: Upgarding only the Linodego client calls and the corresponding Testcases to always set the 'Region' field instead of the 'Cluster' field for creating/fetching a new object storage buckets/or corresponding keys resources using Linodego. To achieve this I am setting the region like below. This PR covers only Step 1:

opts := linodego.ObjectStorageBucketCreateOptions{
Region: bScope.Bucket.Spec.Cluster,

  1. Step 2: Once the Linodego client calls are handled, A new field in the will be introduced in the CAPL API in the LinodeObjectStorageBucketSpec. And all references of the Spec.Cluster will be replaced.

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.65%. Comparing base (703a6b6) to head (ff82062).
Report is 1 commits behind head on main.

Files Patch % Lines
cloud/scope/object_storage_bucket.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #417      +/-   ##
==========================================
- Coverage   67.50%   66.65%   -0.85%     
==========================================
  Files          42       47       +5     
  Lines        2625     2912     +287     
==========================================
+ Hits         1772     1941     +169     
- Misses        746      850     +104     
- Partials      107      121      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eljohnson92 eljohnson92 changed the title [deprecation] linodego update from 1.36.2 to 1.37.0 [deps] linodego update from 1.36.2 to 1.37.0 Jul 20, 2024
@eljohnson92 eljohnson92 added dependencies Pull requests that update a dependency file and removed deprecation labels Jul 22, 2024
@unnatiagg unnatiagg merged commit b5ab05a into main Jul 22, 2024
11 of 12 checks passed
@AshleyDumaine AshleyDumaine deleted the linodego-update branch August 9, 2024 17:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants