Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[feat] Add ObjectStorageKey #426

Merged
merged 17 commits into from
Aug 1, 2024
Merged

[feat] Add ObjectStorageKey #426

merged 17 commits into from
Aug 1, 2024

Conversation

bcm820
Copy link
Contributor

@bcm820 bcm820 commented Jul 24, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 84.09894% with 45 lines in your changes missing coverage. Please review.

Project coverage is 66.27%. Comparing base (bd77f69) to head (bd2fd79).

Files Patch % Lines
controller/linodeobjectstoragekey_controller.go 80.15% 24 Missing and 2 partials ⚠️
cmd/main.go 0.00% 11 Missing ⚠️
api/v1alpha2/linodeobjectstoragekey_types.go 33.33% 4 Missing ⚠️
cloud/scope/object_storage_key.go 95.87% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
+ Coverage   64.89%   66.27%   +1.38%     
==========================================
  Files          72       76       +4     
  Lines        3606     3887     +281     
==========================================
+ Hits         2340     2576     +236     
- Misses       1081     1122      +41     
- Partials      185      189       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bcm820 bcm820 marked this pull request as ready for review July 29, 2024 14:36
@bcm820 bcm820 added feature New feature or request go Pull requests that update Go code testing Pull requests that improve tests labels Jul 29, 2024
@bcm820 bcm820 force-pushed the add-objectstoragekey branch from 2463833 to 877055c Compare July 29, 2024 19:19
@bcm820 bcm820 force-pushed the add-objectstoragekey branch from b5db82b to 701c635 Compare July 29, 2024 19:25
@bcm820 bcm820 merged commit 1b4a2b9 into main Aug 1, 2024
13 checks passed
@bcm820 bcm820 deleted the add-objectstoragekey branch August 1, 2024 14:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature New feature or request go Pull requests that update Go code new-feature testing Pull requests that improve tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants