Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[fix] cluster-autoscaler was pulling an incorrect image when setting up kubeadm-full #437

Merged

Conversation

prajwalvathreya
Copy link
Contributor

What this PR does / why we need it:

  • While setting up kubeadm-full, the cluster-autoscaler pulls in an incorrect image from registry.k8s.io
  • The latest available version of cluster-autoscaler while creating this PR is v1.30.2 , while the specified version in the codebase was v9.37.0

Which issue(s) this PR fixes :

  • Fixes the image pull error when creating the cluster-autoscaler pod

Special notes for your reviewer:

  • Currently this fix hardcodes the version to v1.30.2
  • To avoid further versioning issues, we could include a bash script in the manifest to fetch the current k8s version from the environment and plug that in

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.14%. Comparing base (e058793) to head (7d37444).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #437   +/-   ##
=======================================
  Coverage   66.14%   66.14%           
=======================================
  Files          76       76           
  Lines        3908     3908           
=======================================
  Hits         2585     2585           
  Misses       1131     1131           
  Partials      192      192           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cbzzz
cbzzz previously approved these changes Aug 5, 2024
Copy link
Contributor

@cbzzz cbzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great moves, keep it up 🚽

Co-authored-by: cbzzz <69888673+cbzzz@users.noreply.github.com>
@prajwalvathreya prajwalvathreya merged commit 568ee38 into main Aug 6, 2024
13 checks passed
@AshleyDumaine AshleyDumaine deleted the kubeadm-full-cluster-autoscaler-image-pull-error-fix branch August 6, 2024 15:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants