Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[CI] support older bash versions in generate-flavors.sh #446

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

eljohnson92
Copy link
Collaborator

What this PR does / why we need it:
this PR adds some more conditionals in generate-flavors.sh to support the older bash versions shipped with MacOS.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.03%. Comparing base (b6e8121) to head (080a569).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #446   +/-   ##
=======================================
  Coverage   66.03%   66.03%           
=======================================
  Files          76       76           
  Lines        3945     3945           
=======================================
  Hits         2605     2605           
  Misses       1143     1143           
  Partials      197      197           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amold1 amold1 merged commit 8ab18ac into main Aug 8, 2024
12 checks passed
@AshleyDumaine AshleyDumaine deleted the generate-flavors-update branch August 8, 2024 20:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants